-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Ensure line is unfolded when highlighting for error #8458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Build completed.
Please test this code using one of the following:
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8458-BUILD-825-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8458-BUILD-825-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8458-BUILD-825-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8458-BUILD-825-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8458-BUILD-825-linuxarm.tar.xz
i️ The linuxarm build is still experimental and may not be always available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice facchinm!
Fixes arduino#8457 For some reason, getCurrentTab().getTextArea().getFoldManager().ensureOffsetNotInClosedFold(line) doesn't work here; there no documentation on what offset is. Also, getFoldForLine(line) returns null even if the line is folded (bug in rsyntaxtextarea?)
fdb9201 to
46b0553
Compare
Uh oh!
There was an error while loading. Please reload this page.
Fixes #8457
For some reason,
getCurrentTab().getTextArea().getFoldManager().ensureOffsetNotInClosedFold(line)doesn't work here; there no documentation on what offset is.Also,
getFoldForLine(line)returns null even if the line is folded (bug in rsyntaxtextarea?)@per1234