Fix LookAndFeel loader NPE if missing libgtk2.0 #8132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cmaglie merged 2 commits into arduino:master from cmaglie:fix-gtk-lnf

Nov 5, 2018

Merged

Fix LookAndFeel loader NPE if missing libgtk2.0 #8132

cmaglie merged 2 commits into arduino:master from cmaglie:fix-gtk-lnf

Nov 5, 2018

Conversation

cmaglie

Copy link

Member

@cmaglie cmaglie commented Oct 24, 2018

Alternative to #8122 to fix issue #8119

cmaglie added 2 commits

October 24, 2018 18:52

@cmaglie


 Fix LookAndFeel loader

d937fe9

Fix arduino#8119
Close arduino#8122

@cmaglie


 Override desktop check when setting look and feel on linux

3e0a0a3

The swing UIManager class detects the correct look and feel settings by
looking inside the `sun.desktop` system property, here's the extract of
the JDK:
 String desktop = AccessController.doPrivileged(new GetPropertyAction("sun.desktop"));
 Toolkit toolkit = Toolkit.getDefaultToolkit();
 if ("gnome".equals(desktop) &&
 toolkit instanceof SunToolkit &&
 ((SunToolkit) toolkit).isNativeGTKAvailable()) {
 // May be set on Linux and Solaris boxs.
 return "com.sun.java.swing.plaf.gtk.GTKLookAndFeel";
 }
Since we want always the GTK look and feel (even if the desktop is not
strictly a GNOME desktop) we force the `sun.desktop` property always to
`gnome`.

@ArduinoBot

Copy link

Contributor