Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change error output color to brighter orange #7551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost wants to merge 1 commit into arduino:master
base: master
Choose a base branch
Loading
from unknown repository
Open

Change error output color to brighter orange #7551

ghost wants to merge 1 commit into arduino:master from unknown repository

Conversation

Copy link

@ghost ghost commented May 2, 2018

Addressed issue #7451 by changing the color of error output to a brighter orange color.

Copy link
Collaborator

Looks good. Care to add a screenshot of how this looks (and let's try to prevent too much bikeshedding :-p).

feikname reacted with thumbs up emoji

Copy link
Author

ghost commented May 3, 2018

Sure! I'm including a screenshot with three different colors for error output. The leftmost one is the original color, the middle is an intermediate color I tested, and the rightmost one is the final color I committed.
comparison

facchinm reacted with thumbs up emoji

Copy link
Member

facchinm commented May 7, 2018

@00alis what about it?

Copy link
Author

ghost commented May 7, 2018

Hello, I just went back to the issue request that requested this fix and realized that the problem was not the brightness of the orange color, but certain colors in general. I am including a picture with the error output color in white (what the person is now asking for). I originally did not stray from the color orange because I did not want to break the traditional look, but maybe the change to white could help make the IDE more accessible.
ffffff

per1234 reacted with thumbs down emoji

@per1234 per1234 added the On Hold The pull request is blocked from being merged label May 7, 2018
Copy link
Collaborator

per1234 commented May 7, 2018

I put this PR on hold because feedback indicates it does not at all resolve #7451.

Copy link
Contributor

00alis commented May 9, 2018

I agree the colors are hard to read on certain screens, it is quite an hard task to make it work everywhere. On the Web IDE we are using the following palette:
Green (debug content, does not appear if you turn off Show Verbose output) #1da086
White (normal output)
Yellow (warning) #F1C40F
Red (error) #DA5B4A

Would you mind applying the same palette to your PR and let us know your thoughts?

screenshot 2018年05月09日 11 49 08

Copy link
Collaborator

Note that the web IDE does not currently distinguish warnings and debug output, though I believe to some degree it could (for warnings/debug output generated by the IDE itself or arduino-builder, not for external processes like the compiler).

Copy link

lmihalkovic commented May 9, 2018
edited
Loading

I did this in my local IDE. It is a trivial task and not much more work to extend the coloring to the entire lines (actually easier than to paint only a small part of the message). The part that is highlighted navigates to the relevant part of the source code.. personally, I find it useful (motivated me to chase all the warnings in my code)

screen shot 2018年05月03日 at 8 54 42 am

I'll try with the unofficial-official colors.

Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Alogitt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
On Hold The pull request is blocked from being merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /