-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Use const pointers in Stream::find() and Stream::findUntil() #6927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@facchinm
facchinm
added
the
Print and Stream class
The Arduino core library's Print and Stream classes
label
Nov 14, 2017
👋 Can someone have a look?
Hi @bblanchon ,
we are closing all the API related PRs in this repo.
If you are still interesting in getting this merged could you reopen in https://github.com/arduino/ArduinoCore-api ? Here you can find some hints about reapplying the patch to that repo easily.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Changed the signatures of
Stream::find()andStream::findUntil()to take const pointers, as they don't change the target.find(char *target)find(const char *target)findUntil(char *target, char *terminator)findUntil(const char *target, const char *terminator)All the overloads have been changed accordingly.
This should not cause any code to break.