[windows] Do not unzip jnidispatch.dll in tmp folder #6052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

cmaglie wants to merge 2 commits into arduino:master from cmaglie:win-no-jna-tmp

Closed

[windows] Do not unzip jnidispatch.dll in tmp folder #6052

cmaglie wants to merge 2 commits into arduino:master from cmaglie:win-no-jna-tmp

Conversation

cmaglie

Copy link

Member

@cmaglie cmaglie commented Mar 9, 2017

Normally if jnidispatch.dll is not installed system-wide, JNA tries to extract it from his own jar into the temp folder and tries to load from there.
This is being restriscted on Microsoft Apps and this patch prevents this behaviour.

@cmaglie


 JNA: try to avoid unzipping jnidispatch.dll from jar on Windows

a59cf8e

Normally if JNA doesn't find the jnidispatch.dll it tries to extract
it from the jar into a temp folder and load from there.
This is being restriscted on Microsoft Apps for the app-store and this
commit prevents this behaviour.

@cmaglie cmaglie added Component: IDE feature request labels

Mar 9, 2017

@cmaglie cmaglie added this to the Release 1.8.2 milestone

Mar 9, 2017

@cmaglie cmaglie self-assigned this

Mar 9, 2017

@mastrolinux mastrolinux added the in progress label

Mar 9, 2017

@cmaglie


 During windows build use "icacls" tool to change file attributes

f09b24c

Previously the ant call "chmod" was used, but this is a no-op on Windows,
so it would works only if the IDE is cross-built from a unix host.
This patch allows to build a distribution of the IDE also from a Windows host.