Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[WIP] Make serial monitor hyperlink-aware #5804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
facchinm wants to merge 3 commits into arduino:master
base: master
Choose a base branch
Loading
from facchinm:clickable_serial_monitor

Conversation

Copy link
Member

@facchinm facchinm commented Jan 4, 2017

Add hyperlink listener capabilities to the serial monitor.

The links are automatically created if http/https/ftp pattern is found, but a full <a href ... </a> style can be used and the output won't be mangled (useful if you want to make clickable links with loooong URLs).

No corner case is considered, cpu usage could ramp to 1000% or similar, so use it with a grain of salt (and report any unexpected behaviour/bug)

vbauer reacted with thumbs up emoji
Copy link
Member

cmaglie commented Jan 4, 2017

I remember that the serial monitor has been carefully tuned for performance in previous pull-request: #2491

Before merging we should check if those changes brings back all the poor behaviours that were solved on #2491 in particular the CPU usage when the serial monitor is flooded with data.

 

The HTML view only activates if:
- the output is steady
- the "frame" contains a link
- the length of the entire content is < 1KB
No performance penalty compared to normal view (in standard conditions)
@facchinm facchinm force-pushed the clickable_serial_monitor branch from ee3319d to 1294f86 Compare January 10, 2017 13:55
@facchinm facchinm added Component: IDE The Arduino IDE Component: IDE user interface The Arduino IDE's user interface labels Jan 20, 2017
@facchinm facchinm added this to the Release 1.8.2 milestone Feb 8, 2017
@facchinm facchinm added the Component: IDE Serial monitor Tools > Serial Monitor label Feb 10, 2017
@facchinm facchinm removed this from the Release 1.8.2 milestone Feb 28, 2017
@facchinm facchinm added this to the Release 1.8.3 milestone Mar 20, 2017
@arduino arduino deleted a comment from ArduinoBot Jul 18, 2017
@cmaglie cmaglie modified the milestones: Release 1.8.3, Next Jul 18, 2017
@arduino arduino deleted a comment from ArduinoBot Jul 25, 2017
Copy link
Contributor

@facchinm @cmaglie do we still want to include this in a future IDE release?

@sandeepmistry sandeepmistry added the Waiting for feedback More information must be provided before we can proceed label Sep 17, 2019
Copy link
Member Author

I think it might still be valuable for some Serial monitor based IoT tutorials, maybe with a better implementation 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: IDE Serial monitor Tools > Serial Monitor Component: IDE user interface The Arduino IDE's user interface Component: IDE The Arduino IDE Waiting for feedback More information must be provided before we can proceed
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /