-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Fix data loss when adding an existing file to sketch #5786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the previous version could handle the case, it only did so after deleting the destination file, therefore causing data loss.
@facchinm
facchinm
added
Component: IDE
The Arduino IDE
feature request
A request to make an enhancement (not a bug fix)
labels
Jan 2, 2017
Thank you!
There is no problem with localization strings, they are updated automatically with gettext
(we run this tool periodically to cleanup/update translations).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
addFile
function checks for the case where source and destination are equal, for example when the user wants to update a sketch file modified outside the editor. However, the casing logic will delete the 'old' destination file before that, which causes the file to be lost.Steps to reproduce (tested on Windows)
The changes in this PR: