-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Filter examples based on contributed libraries by architecture #4828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Build completed.
Please test this code using one of the following:
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4828-BUILD-548-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4828-BUILD-548-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4828-BUILD-548-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4828-BUILD-548-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4828-BUILD-548-linuxarm.tar.xz
i️ The linuxarm build is still experimental and may not be always available.
@facchinm this looks good on OS X.
When I select a SAMD core board, the following examples are visible for the USBHost library:
- ADKTerminalTest
- KeyboardController
- MouseController
- USB_desc
and for SAM:
- ADKTerminalTest
- KeyboardController
- MouseController
Which lines up with:
Filter examples based on contributed libraries by architecture
Adds "COMPATIBLE" filter for Contributed libraries, this is not enough to ensure that the correct examples get displayed because the
addOrReplaceroutine overrides the previous results.Adding an architecture-aware routine to handle this (overrides old library only if the the architecture field is compatible)
Solves #4762, to be tested with nightly (
arduino-builder>= 1.3.15)