-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Move SoftwareSerial TX and RX pin setup from constructor to begin #4092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SoftwareSerial TX and RX pin setup from constructor to begin #4092
Conversation
The functions are used only once. You can inline them. Via moving the code or similar to the fix you added yesterday (always inline in header declaration).
Also would possibly resolve: https://github.com/arduino/Arduino/issues/4752
✅ Build completed.
Please test this code using one of the following:
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4092-BUILD-651-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4092-BUILD-651-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4092-BUILD-651-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4092-BUILD-651-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4092-BUILD-651-linuxarm.tar.xz
i️ The linuxarm
build is still experimental and may not be always available.
Humancell
commented
Feb 22, 2018
Is there a reason this has not yet been rolled into the released code? Or how can I assist in making this happen? It would be extremely useful in numerous projects that I'm working on.
Thanks!
CLAassistant
commented
Apr 9, 2021
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
As suggested in #3041.