Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Move SoftwareSerial TX and RX pin setup from constructor to begin #4092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandeepmistry wants to merge 2 commits into arduino:master
base: master
Choose a base branch
Loading
from sandeepmistry:software-serial-begin-pin-setup

Conversation

Copy link
Contributor

@sandeepmistry sandeepmistry commented Nov 5, 2015

As suggested in #3041.

@sandeepmistry sandeepmistry added Library: SoftwareSerial The SoftwareSerial Arduino library Component: Core Related to the code for the standard Arduino API labels Nov 5, 2015
Copy link
Contributor

NicoHood commented Nov 6, 2015

The functions are used only once. You can inline them. Via moving the code or similar to the fix you added yesterday (always inline in header declaration).

Copy link
Contributor

Also would possibly resolve: https://github.com/arduino/Arduino/issues/4752

per1234 reacted with thumbs up emoji

Copy link

Is there a reason this has not yet been rolled into the released code? Or how can I assist in making this happen? It would be extremely useful in numerous projects that I'm working on.

Thanks!

Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Labels
Component: Core Related to the code for the standard Arduino API Library: SoftwareSerial The SoftwareSerial Arduino library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /