Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Cmd+Shift+Left/Right selects from cursor to start/end of line (OS X) #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ffissore merged 1 commit into arduino:master from damellis:osx-line-selection
Jun 8, 2015

Conversation

Copy link
Contributor

@damellis damellis commented Jun 4, 2015

Instead of selecting the entire line. This brings it closer to the standard / expected behavior on OS X (and matches what I see in Processing 3.0a9).

After applying this commit, the behavior is still slightly different than what you see in other OS X applications, but I think it's close enough. (The standard behavior is for the cursor to disappear once there's a selection, at which point Cmd+Shift+Left/Right/Up/Down always adds to the current selection, as opposed to moving the active end of the current selection, which can either add to or subtract from the selection. Weirdly, though, Shift+Left/Right/Up/Down Alt+Shift+Left/Right/Up/Down move the active end of the selection, rather than always adding to it.) If you wanted to get any closer to the standard behavior, you'd probably need to hide the cursor while text was selected, and I'm not sure if it's worth it.

Copy link
Contributor

ffissore commented Jun 5, 2015

This conflicts with #3238 where cmd+shift+arrow was requested to select the entire line. Stolen a mac from a colleague, I saw @damellis behaviour is what TextEdit does. @Lauszus, can you please comment?

@ffissore ffissore self-assigned this Jun 5, 2015
@ffissore ffissore added this to the Release 1.6.5 milestone Jun 5, 2015
@ffissore ffissore added the Component: IDE user interface The Arduino IDE's user interface label Jun 5, 2015
Copy link
Contributor Author

damellis commented Jun 5, 2015

I would assume @Lauszus was just being imprecise and actually meant "select
the entire line from the cursor", i.e. what this pull request does.
Selecting the entire line is definitely not the standard OS X behavior.

On Fri, Jun 5, 2015 at 3:34 AM, Federico Fissore notifications@github.com
wrote:

This conflicts with #3238 #3238
where cmd+shift+arrow was requested to select the entire line. Stolen a mac
from a colleague, I saw @damellis https://github.com/damellis behaviour
is what TextEdit does. @Lauszus https://github.com/Lauszus, can you
please comment?


Reply to this email directly or view it on GitHub
#3291 (comment).

Copy link
Contributor

Lauszus commented Jun 7, 2015

@damellis yes I was just imprecise. This PR is the correct behaviour!

ffissore added a commit that referenced this pull request Jun 8, 2015
Cmd+Shift+Left/Right selects from cursor to start/end of line (OS X)
@ffissore ffissore merged commit 919cd8f into arduino:master Jun 8, 2015
Copy link
Contributor Author

damellis commented Jun 8, 2015

Thanks!

On Mon, Jun 8, 2015 at 2:54 AM, Federico Fissore notifications@github.com
wrote:

Merged #3291 #3291.


Reply to this email directly or view it on GitHub
#3291 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Labels
Component: IDE user interface The Arduino IDE's user interface
Projects
None yet
Milestone
Release 1.6.5
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /