Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix layout for Find-Replace dialog (round 2) #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 4 commits into arduino:ide-1.5.x from cmaglie:wayoda-fix-find-dialog-layout
Jan 13, 2015

Conversation

Copy link
Member

@cmaglie cmaglie commented Jan 7, 2015

This pull request fix the layout of Find/Replace dialog box, as explained in #2419 #2424

Tested on linux. To be tested on Mac and Win.

/cc @wayoda

@cmaglie cmaglie added this to the Release 1.5.9 milestone Jan 7, 2015
@cmaglie cmaglie self-assigned this Jan 7, 2015
@cmaglie cmaglie added Component: IDE The Arduino IDE Component: IDE user interface The Arduino IDE's user interface feature request A request to make an enhancement (not a bug fix) and removed Component: IDE The Arduino IDE labels Jan 7, 2015
Copy link

wayoda commented Jan 8, 2015

Works for me on Linux (Gtk, Nimbus, Metal L&F) and Windows 7

On Linux standard-L&F (Gtk) the dialog window gets pretty wide: Switching to a vertical layout for the checkboxes BoxLayout.PAGE_AXIS vs. BoxLayout.LINE_AXIS

Line 124 JPanel checkboxPanel = new JPanel();
Line 125 checkboxPanel.setLayout(new BoxLayout(checkboxPanel, BoxLayout.PAGE_AXIS));

looks more pleasent to me, but is probably a matter of personal taste:

fixed-searchandreplace-gtk-vertical

Copy link

wayoda commented Jan 8, 2015

"Search all Sketch Tabs" is not translated into german.

I don't really know how the i18n system in the Arduino project works, but if someone knows how to fix this the german translation for
"Search all Sketch Tabs" would be "In allen Tabs suchen"

@cmaglie cmaglie merged commit 9211849 into arduino:ide-1.5.x Jan 13, 2015
@cmaglie cmaglie deleted the wayoda-fix-find-dialog-layout branch January 13, 2015 22:30
Copy link
Member Author

cmaglie commented Jan 14, 2015

@wayoda
thanks for the contribution!

For the translations we use Transifex:
https://www.transifex.com/projects/p/arduino-ide-15/

You can subscribe and edit the translations straight away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Labels
Component: IDE user interface The Arduino IDE's user interface feature request A request to make an enhancement (not a bug fix)
Projects
None yet
Milestone
Release 1.6.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /