-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add check for bridge #2353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for bridge #2353
Conversation
As in #2781, I did not merge this PR because it's more like an hack than a real fix.
In fact, the "XX" command you are sending triggers this function (https://github.com/arduino/YunBridge/blob/master/bridge/packet.py#L98) which launches usr/bin/blink-start (unwanted) and returns 2.
A real "ping" function would be a good improvement but must be implemented by both side of the Bridge; on the python side it will be something like
self.processor.register('Q', PING_Command(self))
I compiled a list of commands already in use https://gist.github.com/facchinm/569c1c8d112d28d8ff73 so if you want to update your merge request dividing it in two parts (one here and one for YunBridge) while keeping the same functionality it would be great!
Thanks for the feedback. I might look into creating a correct ping, if I find some time.
to be used in conjuntion with "Bridge: add PING-like function" in YunBridge
This will allow restarting bridge connection. Hack for #2028.