-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Board Manager: searching returns also near matches #11096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Build completed.
Please test this code using one of the following:
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-11096-BUILD-988-linux32.tar.xz
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-11096-BUILD-988-linux64.tar.xz
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-11096-BUILD-988-windows.zip
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-11096-BUILD-988-macosx.zip
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-11096-BUILD-988-linuxarm.tar.xz
i️ The linuxarm
build is still experimental and may not be always available.
The original filter would only populate the contribution list with perfect matches. Previously, if a core was installed but didn't match the search it wouldn't appear in the results (due to a board being added or the description changed); the user could then install (not upgrade) the core, triggering a confusing situation. When moving to arduino-cli backend we should take care of this issue, at least visually (the cli logic would correctly update/downgrade the core)
46880bd
to
aef6d2a
Compare
✅ Build completed.
Please test this code using one of the following:
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-11096-BUILD-992-linux32.tar.xz
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-11096-BUILD-992-linux64.tar.xz
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-11096-BUILD-992-windows.zip
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-11096-BUILD-992-macosx.zip
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-11096-BUILD-992-linuxarm.tar.xz
i️ The linuxarm
build is still experimental and may not be always available.
The original filter would only populate the contribution list with perfect matches.
Previously, if a core was installed but didn't match the search it wouldn't appear in the results (due to a board being added or the description changed);
the user could then install (not upgrade) the core, triggering a confusing situation.
When moving to arduino-cli backend we should take care of this issue, at least visually (the cli logic would correctly update/downgrade the core)
@per1234 I couldn't find the relevant issues for this fix; I'm quite sure there are a couple 🙂
It would be great you can cross reference them here.
All Submissions:
New Feature Submissions:
Changes to Core Features: