-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add Shift+click on serial monitor toolbar button to open serial plotter #11028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Shift+click on serial monitor toolbar button to open serial plotter #11028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, sounds like a useful change.
I had a quick look at the code, looks good to me. I haven't tested the code, though.
Thank you!
It shouldn't create problems because I used the very same fashion of other buttons.
I built arduino-1.8.14-windows and it works fine in every common situation (I'm using it on daily basis to work on multiple projects), it's very handy!
If I can help further, just let me know 👍
Thank you for the contribution, very handy indeed 😉
Feature
The change involves the Serial Monitor button on the toolbar.
Changed files
Details
I added the
if(isShiftDown)check on the Serial Monitor button, too. In case of Shift being pressed down,editor.handlePlotter()is invoked. I changed the title of the button accordingly to this.As you can see in the picture, works fine on Windows.