rebuildProgrammerMenu: Handle no current board #10922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facchinm merged 1 commit into arduino:master from matthijskooijman:fix-no-board-null-pointer

Dec 1, 2020

Merged

rebuildProgrammerMenu: Handle no current board #10922

facchinm merged 1 commit into arduino:master from matthijskooijman:fix-no-board-null-pointer

Dec 1, 2020

Conversation

matthijskooijman

Copy link

Collaborator

@matthijskooijman matthijskooijman commented Nov 4, 2020 •

edited

Loading

rebuildProgrammerMenu: Handle no current board

This can happen happen in some unlikely cases (such as when renaming a
platform in a way that breaks the "select a board when none is selected
logic").

Even though a board should always be selected, code should still handle
no selected board gracefully (rather than raising a NullPointerException
like this used to do).

See #10887 for the underlying issue that caused no board to be selected.

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@matthijskooijman


 rebuildProgrammerMenu: Handle no current board

61e12d5

This can happen happen in some unlikely cases (such as when renaming a
platform in a way that breaks the "select a board when none is selected
logic").
Even though a board should always be selected, code should still handle
no selected board gracefully (rather than raising a NullPointerException
like this used to do).
See arduino#10887 for the underlying issue that caused no board to be selected.