Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Show maintainer instead of author in lib manager #10849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 1 commit into arduino:master from cmaglie:show-maintainer-in-lib-manager
May 10, 2021

Conversation

Copy link
Member

@cmaglie cmaglie commented Oct 12, 2020

luigigubello reacted with hooray emoji
if (author != null && !author.isEmpty()) {
if (maintainer != null && !maintainer.isEmpty()) {
desc = setButtonOrLink(moreInfoButton, desc, moreInfoLbl, website);
}
Copy link
Collaborator

@matthijskooijman matthijskooijman Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly related to this change, but why does this if exist? Seems like you don't get a "More info" button/link when no author (or now maintainer) is set, but that doesn't make sense to me?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it should be website != null && !website.isEmpty(), I guess we may fix it together with this PR.

@facchinm facchinm added this to the Release 1.8.14 milestone Dec 1, 2020
@cmaglie cmaglie merged commit 7a9db6c into arduino:master May 10, 2021
@cmaglie cmaglie deleted the show-maintainer-in-lib-manager branch May 10, 2021 13:55
Copy link
Contributor

Great work Tooling team! 💯 🦄
cmaglie, rsora, silvanocerza, ubidefeo, per1234, and umbynos reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthijskooijman matthijskooijman matthijskooijman left review comments

+1 more reviewer

@luigigubello luigigubello luigigubello approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /