-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Lib manager filters fix #10440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lib manager filters fix #10440
Conversation
The filters content is unlikely to change, so just prevent it from live updating it because it has some side effects: - it's slow - it changes the selection back to the default and it's very tricky to make it re-select the previous selection. Fixes arduino#10439
Previously changing "Category" would filter libraries by the selected category but without applying the "Type" previously selected. For instance selecting Type="Installed" and Category="Communication" will display *all* the libraries belonging to "communication" instead of the installed only. This commit fix this behavior.
@rsora
rsora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪲
✅ Build completed.
Please test this code using one of the following:
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10440-BUILD-978-linux32.tar.xz
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10440-BUILD-978-linux64.tar.xz
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10440-BUILD-978-windows.zip
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10440-BUILD-978-macosx.zip
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10440-BUILD-978-linuxarm.tar.xz
i️ The linuxarm
build is still experimental and may not be always available.
This PR fixes two bugs in library manager combo-box Type and Category filters: