Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Lib manager filters fix #10440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 3 commits into arduino:master from cmaglie:lib_manager_filters_fix
Jul 15, 2020
Merged

Conversation

Copy link
Member

@cmaglie cmaglie commented Jun 29, 2020

This PR fixes two bugs in library manager combo-box Type and Category filters:

  • The filters are both reset to "All" after an install/update operation
  • Changing the Category will show the all the libraries belonging to that category regardless of the "Type" selection (for example if you selected "Installed" or "Upgradable" before changing the category)

cmaglie added 3 commits June 29, 2020 16:58
The filters content is unlikely to change, so just prevent it from live
updating it because it has some side effects:
- it's slow
- it changes the selection back to the default and it's very tricky to
 make it re-select the previous selection.
Fixes arduino#10439 
Previously changing "Category" would filter libraries by the selected
category but without applying the "Type" previously selected.
For instance selecting Type="Installed" and Category="Communication"
will display *all* the libraries belonging to "communication" instead of
the installed only.
This commit fix this behavior.
@cmaglie cmaglie added this to the Release 1.8.14 milestone Jun 29, 2020
@cmaglie cmaglie self-assigned this Jun 29, 2020
@cmaglie cmaglie added Component: Board/Lib Manager Boards Manager or Library Manager Component: IDE user interface The Arduino IDE's user interface Type: Bug labels Jun 29, 2020
Copy link

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪲

@cmaglie cmaglie merged commit bf24880 into arduino:master Jul 15, 2020
@cmaglie cmaglie deleted the lib_manager_filters_fix branch July 15, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
Component: Board/Lib Manager Boards Manager or Library Manager Component: IDE user interface The Arduino IDE's user interface Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /