-
Notifications
You must be signed in to change notification settings - Fork 164
feat: Add Programmed External Keys. #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arduino sketch filenames may not contain spaces.
The sketch filename must exactly match the folder name:
Keyboard
|_examples
|_ProgrammableButtons
|_ProgrammableButtons.ino
Please do a Tools > Auto Format if using the Arduino IDE or a Ctrl + B if using Arduino Web Editor to ensure the formatting of your code matches that of the other official Arduino example sketches.
Please always thoroughly test your code before submitting contributions.
Please set File > Preferences > Compiler Warnings to "All" and make sure your code doesn't generate any warnings.
Formating Done Co-Authored-By: per1234 <accounts@perglass.com>
I will take care of all the other suggestions too.
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Control structures simplified Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Example for native USB Arduino boards (e.g., Leonardo, Micro, MKR, Nano 33 IoT, Zero, Due) - When the first button is pressed, the Ctrl + C keyboard shortcut (copy) is emulated. -When the second button is pressed, the Ctrl + V keyboard shortcut (paste) is emulated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@per1234 I think I have done all the suggested changes.
Let me know if there are still any issues/suggestions, which need to be resolved.
Thank you for your time & suggestions :)
Co-Authored-By: per1234 <accounts@perglass.com>
Making Trigger when pinstate is HIGH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@per1234
Thank you for guiding me through this :) 👍
Please check this #33 (comment) comment too.
I have done all the requested changes. Please review..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@per1234
Done with all the requested changes. (including the button trigger)
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @per1234 👍 :)
I have implemented all of the required changes. :)
Please review it again :)
Requested changes have been made. Thanks!
@per1234 Can we merge the Example?
@TheShubham99 I'm not the person who decides which pull requests get merged. I only share my opinions in PR reviews in hopes it will be helpful.
Arduino's developers have a huge amount of software to maintain and are always working on very important and exciting projects. When you submit a pull request, you need to be willing to be patient. We should avoid making unproductive comments on the pull request threads, as the "noise" may cause the developers to be less productive in their important work, and thus result in longer delays before they can find the time to review non-essential pull requests.
CLA assistant check
All committers have signed the CLA.
This example shows how to use external buttons/keys as a keyboard using Keyboard Library