-
Notifications
You must be signed in to change notification settings - Fork 164
Created KeyboardandMousecontrol.ino #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please spell the sketch name the same as in the existing example sketch: KeyboardAndMouseControl
As I brought up in arduino-libraries/Mouse#13 (comment):
One thing to note is that this example already comes bundled with the Arduino IDE (and Arduino Web Editor) under File > Examples > 09.USB > KeyboardAndMouseControl .
It does make sense to bundle the examples with the library since the IDE bundled examples are not available to arduino-cli and Arduino Pro IDE users. I don't like the idea of having duplicate code to maintain, but it also could be problematic to remove the built-in sketches since there are likely tutorials that point people to that menu path. I suppose we could replace the content of the built in sketches with a comment like:
// This example has been moved to File > Examples > Keyboard > KeyboardLogout(should be adapted to make sense for Arduino Web Editor users also)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend also adding the layout and schematic files from https://github.com/arduino/Arduino/tree/master/build/shared/examples/09.USB/KeyboardAndMouseControl
@per1234 thank you so much for your valuable suggestions sir, will get right onto it and make the needful changes.
Co-Authored-By: per1234 <accounts@perglass.com>
@per1234 I've done the requested changes and would be grateful if you can review them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes no sense. The example has not been moved to File > Examples > USB > KeyboardAndMouseControl. The example has always been there. The whole point of your pull request is to move (or copy) that sketch FROM File > Examples > USB > KeyboardAndMouseControl TO File > Examples > Mouse > KeyboardAndMouseControl.
There is no benefit to providing a link to the copy of the sketch in the arduino/Arduino repository. If they saw that comment, the user is already looking at the sketch.
CLAassistant
commented
Apr 9, 2021
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
This code would be really helpful for new users and so it'll be great if this code is present in the library itself