Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(HCI): SetAdvertise only if enabled #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pennam merged 1 commit into arduino-libraries:master from fpistm:advertising_enabled
Apr 14, 2025

Conversation

Copy link
Contributor

@fpistm fpistm commented Apr 10, 2025

No description provided. 

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Copy link

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 13.69%. Comparing base (ab1ea93) to head (b7c6120).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
src/utility/HCI.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 9.62% 13.69% +4.06% 
==========================================
 Files 28 28 
 Lines 3656 3666 +10 
==========================================
+ Hits 352 502 +150 
+ Misses 3304 3164 -140

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Memory usage change @ b7c6120

Board flash % RAM for global variables %
arduino:mbed_nano:nano33ble 🔺 0 - +64 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 +16 - +16 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:megaavr:uno2018:mode=on 🔺 +6 - +6 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 0 - +16 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 +16 - +16 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 +16 - +16 +0.01 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Central/LedControl
flash		 % examples/Central/LedControl
RAM for global variables		 % examples/Central/PeripheralExplorer
flash		 % examples/Central/PeripheralExplorer
RAM for global variables		 % examples/Central/Scan
flash		 % examples/Central/Scan
RAM for global variables		 % examples/Central/ScanCallback
flash		 % examples/Central/ScanCallback
RAM for global variables		 % examples/Central/SensorTagButton
flash		 % examples/Central/SensorTagButton
RAM for global variables		 % examples/Peripheral/Advertising/EnhancedAdvertising
flash		 % examples/Peripheral/Advertising/EnhancedAdvertising
RAM for global variables		 % examples/Peripheral/Advertising/RawDataAdvertising
flash		 % examples/Peripheral/Advertising/RawDataAdvertising
RAM for global variables		 % examples/Peripheral/BatteryMonitor
flash		 % examples/Peripheral/BatteryMonitor
RAM for global variables		 % examples/Peripheral/ButtonLED
flash		 % examples/Peripheral/ButtonLED
RAM for global variables		 % examples/Peripheral/CallbackLED
flash		 % examples/Peripheral/CallbackLED
RAM for global variables		 % examples/Peripheral/EncryptedBatteryMonitor
flash		 % examples/Peripheral/EncryptedBatteryMonitor
RAM for global variables		 % examples/Peripheral/LED
flash		 % examples/Peripheral/LED
RAM for global variables		 %
arduino:mbed_nano:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0
arduino:megaavr:uno2018:mode=on 6 0.01 0 0.0 6 0.01 0 0.0 6 0.01 0 0.0 6 0.01 0 0.0 6 0.01 0 0.0 6 0.01 0 0.0 6 0.01 0 0.0 6 0.01 0 0.0 6 0.01 0 0.0 6 0.01 0 0.0 6 0.01 0 0.0 6 0.01 0 0.0
arduino:renesas_uno:unor4wifi 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 0 0.0 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0
arduino:samd:mkrwifi1010 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0
arduino:samd:nano_33_iot 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0
Click for full report CSV 
Board,examples/Central/LedControl<br>flash,%,examples/Central/LedControl<br>RAM for global variables,%,examples/Central/PeripheralExplorer<br>flash,%,examples/Central/PeripheralExplorer<br>RAM for global variables,%,examples/Central/Scan<br>flash,%,examples/Central/Scan<br>RAM for global variables,%,examples/Central/ScanCallback<br>flash,%,examples/Central/ScanCallback<br>RAM for global variables,%,examples/Central/SensorTagButton<br>flash,%,examples/Central/SensorTagButton<br>RAM for global variables,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>flash,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>RAM for global variables,%,examples/Peripheral/Advertising/RawDataAdvertising<br>flash,%,examples/Peripheral/Advertising/RawDataAdvertising<br>RAM for global variables,%,examples/Peripheral/BatteryMonitor<br>flash,%,examples/Peripheral/BatteryMonitor<br>RAM for global variables,%,examples/Peripheral/ButtonLED<br>flash,%,examples/Peripheral/ButtonLED<br>RAM for global variables,%,examples/Peripheral/CallbackLED<br>flash,%,examples/Peripheral/CallbackLED<br>RAM for global variables,%,examples/Peripheral/EncryptedBatteryMonitor<br>flash,%,examples/Peripheral/EncryptedBatteryMonitor<br>RAM for global variables,%,examples/Peripheral/LED<br>flash,%,examples/Peripheral/LED<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0
arduino:megaavr:uno2018:mode=on,6,0.01,0,0.0,6,0.01,0,0.0,6,0.01,0,0.0,6,0.01,0,0.0,6,0.01,0,0.0,6,0.01,0,0.0,6,0.01,0,0.0,6,0.01,0,0.0,6,0.01,0,0.0,6,0.01,0,0.0,6,0.01,0,0.0,6,0.01,0,0.0
arduino:renesas_uno:unor4wifi,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,0,0.0,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0
arduino:samd:mkrwifi1010,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0
arduino:samd:nano_33_iot,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Apr 10, 2025
@pennam pennam merged commit 5855ec1 into arduino-libraries:master Apr 14, 2025
15 of 16 checks passed
@fpistm fpistm deleted the advertising_enabled branch April 14, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /