Add BLEPermission Support to BLEStringCharacteristic #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pennam merged 2 commits into arduino-libraries:master from pennam:ble-permission

Apr 10, 2025

Merged

Add BLEPermission Support to BLEStringCharacteristic #390

pennam merged 2 commits into arduino-libraries:master from pennam:ble-permission

Apr 10, 2025

Conversation

pennam

Copy link

Contributor

@pennam pennam commented Apr 9, 2025

5 years ago, support for encryption was added by #156. Currently, the BLEEncryption tag needs to be added to require proper encrypted bluetooth pairing. It is possible to add this tag to all other kinds of characteristics except String characteristics.

BLEStringCharacteristic's constructor calls BLECharacteristic's constructor, and BLECharacteristic uses a uint16_t instead of a uint8_t.

This PR simply changes the properties attribute of BLEStringCharacteristic to match the width of the permissions attribute of BLECharacteristic (from 8 to 16 bits) to support the BLEPermission tags in BLEProperty.h.

@porubcinj @pennam


 Add BLEPermission Support to BLEStringCharacteristic

5 years ago, support for encryption was added by arduino-libraries#156.
Currently, the BLEEncryption tag needs to be added to require proper encrypted bluetooth pairing.
It is possible to add this tag to all other kinds of characteristics except String characteristics.
BLEStringCharacteristic's constructor calls BLECharacteristic's constructor, and BLECharacteristic
uses a uint16_t instead of a uint8_t.
This PR simply changes the properties attribute of BLEStringCharacteristic to match the width of
the permissions attribute of BLECharacteristic (from 8 to 16 bits) to support the BLEPermission
tags in BLEProperty.h.

@codecov Codecov

Copy link

codecov bot commented Apr 9, 2025 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.73%. Comparing base (c91c02c) to head (e2bf0c0).
Report is 21 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@
## master #390 +/- ##
==========================================
+ Coverage 9.62% 13.73% +4.10% 
==========================================
 Files 28 28 
 Lines 3656 3656 
==========================================
+ Hits 352 502 +150 
+ Misses 3304 3154 -150

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions

Copy link

github-actions bot commented Apr 9, 2025

Memory usage change @ 7322196

Board	flash	%	RAM for global variables	%
`arduino:mbed_nano:nano33ble`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_nano:nanorp2040connect`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:megaavr:uno2018:mode=on`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:renesas_uno:unor4wifi`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:nano_33_iot`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/Central/LedControl` flash	%	`examples/Central/LedControl` RAM for global variables	%	`examples/Central/PeripheralExplorer` flash	%	`examples/Central/PeripheralExplorer` RAM for global variables	%	`examples/Central/Scan` flash	%	`examples/Central/Scan` RAM for global variables	%	`examples/Central/ScanCallback` flash	%	`examples/Central/ScanCallback` RAM for global variables	%	`examples/Central/SensorTagButton` flash	%	`examples/Central/SensorTagButton` RAM for global variables	%	`examples/Peripheral/Advertising/EnhancedAdvertising` flash	%	`examples/Peripheral/Advertising/EnhancedAdvertising` RAM for global variables	%	`examples/Peripheral/Advertising/RawDataAdvertising` flash	%	`examples/Peripheral/Advertising/RawDataAdvertising` RAM for global variables	%	`examples/Peripheral/BatteryMonitor` flash	%	`examples/Peripheral/BatteryMonitor` RAM for global variables	%	`examples/Peripheral/ButtonLED` flash	%	`examples/Peripheral/ButtonLED` RAM for global variables	%	`examples/Peripheral/CallbackLED` flash	%	`examples/Peripheral/CallbackLED` RAM for global variables	%	`examples/Peripheral/EncryptedBatteryMonitor` flash	%	`examples/Peripheral/EncryptedBatteryMonitor` RAM for global variables	%	`examples/Peripheral/LED` flash	%	`examples/Peripheral/LED` RAM for global variables	%
`arduino:mbed_nano:nano33ble`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_nano:nanorp2040connect`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:megaavr:uno2018:mode=on`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:renesas_uno:unor4wifi`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:nano_33_iot`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/Central/LedControl<br>flash,%,examples/Central/LedControl<br>RAM for global variables,%,examples/Central/PeripheralExplorer<br>flash,%,examples/Central/PeripheralExplorer<br>RAM for global variables,%,examples/Central/Scan<br>flash,%,examples/Central/Scan<br>RAM for global variables,%,examples/Central/ScanCallback<br>flash,%,examples/Central/ScanCallback<br>RAM for global variables,%,examples/Central/SensorTagButton<br>flash,%,examples/Central/SensorTagButton<br>RAM for global variables,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>flash,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>RAM for global variables,%,examples/Peripheral/Advertising/RawDataAdvertising<br>flash,%,examples/Peripheral/Advertising/RawDataAdvertising<br>RAM for global variables,%,examples/Peripheral/BatteryMonitor<br>flash,%,examples/Peripheral/BatteryMonitor<br>RAM for global variables,%,examples/Peripheral/ButtonLED<br>flash,%,examples/Peripheral/ButtonLED<br>RAM for global variables,%,examples/Peripheral/CallbackLED<br>flash,%,examples/Peripheral/CallbackLED<br>RAM for global variables,%,examples/Peripheral/EncryptedBatteryMonitor<br>flash,%,examples/Peripheral/EncryptedBatteryMonitor<br>RAM for global variables,%,examples/Peripheral/LED<br>flash,%,examples/Peripheral/LED<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:megaavr:uno2018:mode=on,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@pennam pennam force-pushed the ble-permission branch from 1e11191 to 7322196 Compare

April 10, 2025 09:30

@pennam


 Add basic test case on characteristic permissions

e2bf0c0

@pennam pennam merged commit 87913ee into arduino-libraries:master

Apr 10, 2025

15 checks passed

@per1234 per1234 added type: imperfection topic: code labels

Apr 13, 2025

Labels

topic: code type: imperfection

3 participants

@pennam @per1234 @porubcinj

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add BLEPermission Support to BLEStringCharacteristic #390

Add BLEPermission Support to BLEStringCharacteristic #390

Uh oh!

Conversation

@pennam pennam commented Apr 9, 2025

Uh oh!

codecov bot commented Apr 9, 2025 •

edited

Loading

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

Uh oh!

Uh oh!

Add BLEPermission Support to BLEStringCharacteristic #390

Add BLEPermission Support to BLEStringCharacteristic #390

Uh oh!

Conversation

@pennam pennam commented Apr 9, 2025

Uh oh!

codecov bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 9, 2025 •

edited

Loading