-
Notifications
You must be signed in to change notification settings - Fork 222
Add function to manage low power mode status #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leonardocavagnis
wants to merge
5
commits into
arduino-libraries:master
from
leonardocavagnis:ble_local_lp_mode
Open
Add function to manage low power mode status #327
leonardocavagnis
wants to merge
5
commits into
arduino-libraries:master
from
leonardocavagnis:ble_local_lp_mode
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@leonardocavagnis
leonardocavagnis
requested review from
sebromero and
facchinm
October 11, 2023 15:06
@leonardocavagnis
leonardocavagnis
linked an issue
Oct 11, 2023
that may be
closed
by this pull request
@per1234
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Oct 11, 2023
sebromero
sebromero
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I'd recommend naming the user facing function setLowPowerModeEnabled or as discussed disableLowPowerMode() if re-enabling it makes no sense. For the other functions I suggest avoiding abbreviations that leave room for ambiguity.
Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>
Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Adding the function
BLE.setLowPowerMode(bool)to manage the lower power mode status of the BLE chip.The function
BLE.setLowPowerMode(bool)(true: to enable,false: to disable) must be called before executing theBLE.begin()function. Using this function after the BLE stack initialization will not have any effect.The function does not directly control the entry and exit from low power mode but enables or disables the chip's feature.
Low power mode is enabled by default.
@sebromero Check it out if function name sounds good. Another proposal could be using two different functions:
enableLowPowerMode()anddisableLowPowerMode().This PR is based on the arduino/mbed-os PR #32.