Fix for issue #245 - ATT_OP_FIND_INFO_RESP incorrect processing durin... #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

carterd wants to merge 1 commit into arduino-libraries:master

from carterd:master

Open

Fix for issue #245 - ATT_OP_FIND_INFO_RESP incorrect processing durin... #263

carterd wants to merge 1 commit into arduino-libraries:master from carterd:master

Conversation

carterd

Copy link

@carterd carterd commented Sep 25, 2022

Fix for issue #245 - ATT_OP_FIND_INFO_RESP incorrect processing during ATTClass::discoverDescriptors causes crashing

I've highlighted this issue on 9th July ... this is an issue of causing CRASHES if using ArduinoBLE to connect as central and the response to ATT_OP_FIND_INFO_RESP includes 128-bit UUIDs.

Please check and remove comments after review

@CLAassistant

Copy link

CLAassistant commented Sep 25, 2022 •

edited

Loading

CLA assistant check
All committers have signed the CLA.

@carterd


 Fix for issue arduino-libraries#245 - ATT_OP_FIND_INFO_RESP incorrect...

387f02b

... processing during ATTClass::discoverDescriptors causes crashing
I've highlighted this issue on 9th July ... this is an issue of causing __CRASHES__ if using ArduinoBLE to connect as central and the response to ATT_OP_FIND_INFO_RESP includes 128-bit UUIDs.

@per1234 per1234 added type: imperfection topic: code labels

Sep 25, 2022

@facchinm

Copy link

Contributor

facchinm commented Sep 26, 2022

Hi @carterd ,
thanks for looking into this! I think the PR can be simplified a bit, I'm adding some inline comments. Will be more than happy to merge afterwards 😉