-
Notifications
You must be signed in to change notification settings - Fork 73
[Feature] Add Gateway Config condition #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Copilot
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds gateway configuration monitoring by implementing a new condition to track the configuration state of Gateway members. The feature introduces a systematic way to monitor whether gateway configurations are present and up-to-date by comparing configuration checksums.
Key changes include:
- Addition of a new
ConditionTypeGatewayConfigcondition type for tracking gateway configuration state - Implementation of gateway configuration monitoring in the reconciler plan builder
- Restructuring of gateway configuration generation to calculate checksums after all destinations are configured
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/deployment/reconcile/plan_builder_gateway.go | New file implementing gateway config condition monitoring logic |
| pkg/deployment/client/inventory.go | New inventory client for fetching gateway configuration data |
| pkg/apis/deployment/v1/conditions.go | Adds the new GatewayConfig condition type constant |
| pkg/deployment/resources/config_map_gateway.go | Reorders configuration generation to calculate checksum after all destinations |
| pkg/deployment/reconcile/plan_builder_high.go | Integrates gateway config condition into the reconciliation plan |
| pkg/deployment/reconcile/plan_builder_context.go | Updates interface to use DeploymentGetter instead of DeploymentInfoGetter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable logger is undefined in this scope. You need to either pass a logger parameter to this function or use a logger from the reconciler context.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded string "Config Present" is repeated multiple times. Consider defining a constant for this message to improve maintainability.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded string "Config is not present" is repeated multiple times. Consider defining a constant for this message to improve maintainability.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fourth parameter should be true instead of false when the config is present, as this indicates the condition status (true = condition is met).
Copilot uses AI. Check for mistakes.
No description provided.