-
-
Notifications
You must be signed in to change notification settings - Fork 427
Conversation
bpiraeus
commented
Mar 14, 2022
I went through the failing tests, and unless I'm missing something, those are not from my changes, not sure what I can do about that short of refactoring someone else's code. I'm happy to muck around if needed, but you'd likely prefer someone with a lot more chops than myself to mitigate those issues.
randombenj
commented
Mar 14, 2022
@bpiraeus It looks like mostly deprecation errors
- x/crypto/openpgp: mark as frozen and deprecated golang/go#44226
- package golang.org/x/crypto/ssh/terminal is deprecated: this package moved to golang.org/x/term
If you want to, feel free to investigate if there are some simple fixes for the deprecated packages (x/term) seems to be quite an easy one, not sure about the crypto one ...
bpiraeus
commented
Mar 14, 2022
Cleaned up a few oddballs in my code that gosimple flagged, also moved the terminal bits to the appropriate package, the pgp ones appear as if they're likely going to want 3rd party library.
neolynx
commented
Aug 13, 2024
introducing authorization per repo is a nice idea.
however, authentication without SSL is not that nice, so probably we should implement this as well with this change.
since different authentication types are supported, the variable LdapGroup should probably AuthorizedGroup
7291b04 to
888025c
Compare
neolynx
commented
Aug 13, 2024
rebased on master
- ldap currently the only supported method adding authorisation options for local repositories - ldap groups per repo
888025c to
ef42975
Compare
neolynx
commented
Nov 1, 2024
@bpiraeus are you still interested in continuing this ?
ddcac3d to
a8e0e3d
Compare
de022db to
4076941
Compare
26ce6fc to
ab18da3
Compare
Fixes #
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
Checklist
AUTHORS