src/lib/components/variables/environmentVariables.svelte (1)

186-207: Merge adjacent identical {#if !variable?.secret} blocks.

Two consecutive blocks check the same condition. Combining them reduces template noise and makes it clearer these actions are grouped.

♻️ Proposed merge

- {`#if` !variable?.secret}
- <ActionMenu.Item.Button
- leadingIcon={IconPencil}
- on:click={(e) => {
- toggle(e);
- currentVariable = variable;
- showUpdate = true;
- }}>
- Update
- </ActionMenu.Item.Button>
- {/if}
- {`#if` !variable?.secret}
- <ActionMenu.Item.Button
- leadingIcon={IconEyeOff}
- on:click={(e) => {
- toggle(e);
- currentVariable = variable;
- showSecretModal = true;
- }}>
- Secret
- </ActionMenu.Item.Button>
- {/if}
+ {`#if` !variable?.secret}
+ <ActionMenu.Item.Button
+ leadingIcon={IconPencil}
+ on:click={(e) => {
+ toggle(e);
+ currentVariable = variable;
+ showUpdate = true;
+ }}>
+ Update
+ </ActionMenu.Item.Button>
+ <ActionMenu.Item.Button
+ leadingIcon={IconEyeOff}
+ on:click={(e) => {
+ toggle(e);
+ currentVariable = variable;
+ showSecretModal = true;
+ }}>
+ Secret
+ </ActionMenu.Item.Button>
+ {/if}

src/lib/components/variables/environmentVariables.svelte (2)

60-60: currentVariable initialized as undefined but typed as Partial<Models.Variable>.

Since the modals that consume currentVariable are guarded by {#if showXxx} and the show flags are only set after currentVariable is assigned (e.g., lines 196–197), this won't cause runtime errors in practice. However, the type is technically inaccurate.

💡 Optional: make the type honest

- let currentVariable = $state<Partial<Models.Variable>>(undefined);
+ let currentVariable = $state<Partial<Models.Variable> | undefined>(undefined);

---

190-212: Two consecutive {#if !variable?.secret} blocks could be merged.

Lines 191 and 202 guard on the same condition. Combining them into a single block reduces template nesting and makes the intent clearer.

Suggested simplification

 <ActionMenu.Root>
- {`#if` !variable?.secret}
- <ActionMenu.Item.Button
- leadingIcon={IconPencil}
- onclick={(e) => {
- toggle(e);
- currentVariable = variable;
- showUpdate = true;
- }}>
- Update
- </ActionMenu.Item.Button>
- {/if}
- {`#if` !variable?.secret}
- <ActionMenu.Item.Button
- leadingIcon={IconEyeOff}
- onclick={(e) => {
- toggle(e);
- currentVariable = variable;
- showSecretModal = true;
- }}>
- Secret
- </ActionMenu.Item.Button>
- {/if}
+ {`#if` !variable?.secret}
+ <ActionMenu.Item.Button
+ leadingIcon={IconPencil}
+ onclick={(e) => {
+ toggle(e);
+ currentVariable = variable;
+ showUpdate = true;
+ }}>
+ Update
+ </ActionMenu.Item.Button>
+ <ActionMenu.Item.Button
+ leadingIcon={IconEyeOff}
+ onclick={(e) => {
+ toggle(e);
+ currentVariable = variable;
+ showSecretModal = true;
+ }}>
+ Secret
+ </ActionMenu.Item.Button>
+ {/if}

src/routes/(console)/project-[region]-[project]/sites/create-site/repositories/repository-[repository]/+page.svelte (1)

127-137: Pre-existing: Promise.all for variable creation has no partial-failure handling.

If one variable creation fails, Promise.all rejects immediately while other requests may still be in-flight. The site and domain will already have been created, potentially leaving partial state. This is pre-existing behavior and not introduced by this PR, but worth noting for future improvement (e.g., Promise.allSettled with error aggregation).