-
Notifications
You must be signed in to change notification settings - Fork 553
Adds Librewolf to web-browser-extension-distribution-information.json #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds Librewolf to web-browser-extension-distribution-information.json
Removes trailing comma
JaminenB
commented
Jul 8, 2025
@rmondello Can this be reviewed to support the Librewolf browser?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a whitespace error here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that this browser doesn’t have a code signing team identifier means that adding it to this list won’t actually make it work with the iCloud Passwords extension. Apps need to be signed.
ajzeigert
commented
Jul 14, 2025
That makes sense. It seems like the app is being signed? But maybe this field is just not set? I'm not super familiar with how code signing works, but here's the output of codesign -dvvv /Applications/LibreWolf.app:
$ codesign -dvvv /Applications/LibreWolf.app
Executable=/Applications/LibreWolf.app/Contents/MacOS/librewolf
Identifier=librewolf
Format=app bundle with Mach-O thin (arm64)
CodeDirectory v=20400 size=552 flags=0x20002(adhoc,linker-signed) hashes=14+0 location=embedded
Hash type=sha256 size=32
CandidateCDHash sha256=f458e182af0da6c2cff9d197a27f1aad17a72671
CandidateCDHashFull sha256=f458e182af0da6c2cff9d197a27f1aad17a726713c06da7e98b17702ea7e62d8
Hash choices=sha256
CMSDigest=f458e182af0da6c2cff9d197a27f1aad17a726713c06da7e98b17702ea7e62d8
CMSDigestType=2
CDHash=f458e182af0da6c2cff9d197a27f1aad17a72671
Signature=adhoc
Info.plist=not bound
TeamIdentifier=not set
Sealed Resources=none
Internal requirements=none
I can also inquire on the official LibreWolf channel how the app is being signed, if at all, for the macOS distribution.
Adds Librewolf to web-browser-extension-distribution-information.json
Overall Checklist