This repository was archived by the owner on May 13, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 76
KKPasscodeSettingsViewControllerDelegate:passcodeLockWillBePresented#11
Open
tiagofernandez wants to merge 3 commits into
Open
KKPasscodeSettingsViewControllerDelegate:passcodeLockWillBePresented #11tiagofernandez wants to merge 3 commits into
tiagofernandez wants to merge 3 commits into
Conversation
... on screen. This feature allows things like dismissing a popover controller on the iPad.
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should check if the function exists in the delegate before invoking it. perhaps some users won't implement this function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added an optional method to KKPasscodeSettingsViewControllerDelegate, in order to notify the delegate that the passcode lock view will be on screen. The reason is to allow things like dismissing a popover controller. Additionally, I've unlocked rotation for the passcode view while on iPad.