-
Notifications
You must be signed in to change notification settings - Fork 0
docs: fix benchmark table separator column count mismatch#164
Conversation
The x86_64 throughput table had an extra separator cell (8 columns vs 7 in the header), and the modify+encode table header alignment was inconsistent (first column missing the colon suffix). Fix both so the Markdown tables render correctly. Fixes #162
Warning
Review limit reached
@membphis, we couldn't start this review because you've reached your PR review rate limit.
More reviews will be available in 39 minutes and 59 seconds. Learn how PR review limits work.
Your organization has run out of usage credits. Purchase more in the billing tab.
⌛ How to resolve this issue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.
Please see our Fair Usage Limits Policy for further information.
i️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 55cf92ac-5858-40b4-9a40-40446217b6ce
📒 Files selected for processing (1)
docs/benchmarks.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
feature-issue-162
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 93f7d8a | Previous: 8e1b394 | Ratio |
|---|---|---|---|
parse_lazy/parse/wide_object |
3932 ns/iter (± 30) |
3478 ns/iter (± 53) |
1.13 |
parse_lazy/parse/deep_nesting |
2768 ns/iter (± 186) |
2623 ns/iter (± 75) |
1.06 |
field_access/get_f64/max_tokens |
49 ns/iter (± 0) |
46 ns/iter (± 0) |
1.07 |
This comment was automatically generated by workflow using github-action-benchmark.
Fixes #162.
This updates malformed Markdown table separator rows in docs/benchmarks.md so their column counts match the corresponding headers. It also checks nearby benchmark tables for the same issue.