Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

[XMLBEANS-617] Support recursing directories (sourceDir configuration parameter)#12

Open
milansanders wants to merge 5 commits intoapache:trunk from
milansanders:trunk
Open

[XMLBEANS-617] Support recursing directories (sourceDir configuration parameter) #12
milansanders wants to merge 5 commits intoapache:trunk from
milansanders:trunk

Conversation

@milansanders
Copy link

@milansanders milansanders commented Dec 21, 2023

Add a config parameter (sourceSubdirs, default false) to allow for checking subdirectories of the sourceDir folder


package org.apache.xmlbeans.impl.tool;

import org.apache.commons.io.FileUtils;
Copy link
Member

@pjfanning pjfanning Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't yet have a compile/runtime dependency on the commons-io jar

commons-io is only currently used in some tests

The POM and build files will need to be changed

It would probably also require us to rename the next release as 5.3.0 because the extra dependenecy makes this a less trivial upgrade.

Copy link
Member

pjfanning commented Jan 1, 2024
edited
Loading

I added a variant of this. See da1e4a2

  • I renamed the plugin config as recurseSourceSubdirs
  • added the license headers
  • made the FileUtil non-public

Tested with https://github.com/pjfanning/xmlbeans-maven-sample/tree/xmlbeans-617

https://issues.apache.org/jira/browse/XMLBEANS-617

Copy link
Author

Awesome, when is this expected to be released?

Copy link
Member

There are no plans for a release. Until we do a release, you can build your own copy of the jar. There is a snapshot at https://ci-builds.apache.org/job/POI/job/POI-XMLBeans-DSL-1.8/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pjfanning pjfanning pjfanning left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /