This repository was archived by the owner on Nov 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 355
Open
Conversation
@ericholguin
ericholguin
added
Traffic Ops
related to Traffic Ops
low impact
affects only a small portion of a CDN, and cannot itself break one
tech debt
rework due to choosing easy/limited solution
labels
Aug 22, 2023
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #7739 +/- ## ============================================= - Coverage 65.05% 32.34% -32.72% Complexity 98 98 ============================================= Files 314 710 +396 Lines 12365 79773 +67408 Branches 907 965 +58 ============================================= + Hits 8044 25799 +17755 - Misses 3968 51828 +47860 - Partials 353 2146 +1793
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just simplifies the conditional used to check if roles and permissions are enabled.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run TO and make sure a user can view a secure parameter value with the right permissions
PR submission checklist