This repository was archived by the owner on Nov 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 355
Fix for Strategies.yaml to include parent_is_proxy and fix some tech debt#7639
Open
cybertunnel wants to merge 4 commits into
Open
Fix for Strategies.yaml to include parent_is_proxy and fix some tech debt #7639cybertunnel wants to merge 4 commits into
cybertunnel wants to merge 4 commits into
Conversation
@ocket8888
ocket8888
added
bug
something isn't working as intended
low impact
affects only a small portion of a CDN, and cannot itself break one
cache-config
Cache config generation
labels
Jul 11, 2023
Codecov Report
@@ Coverage Diff @@ ## master #7639 +/- ## ============================================ + Coverage 30.12% 37.37% +7.24% Complexity 98 98 ============================================ Files 794 250 -544 Lines 84077 12676 -71401 Branches 907 90 -817 ============================================ - Hits 25332 4738 -20594 + Misses 56615 7620 -48995 + Partials 2130 318 -1812
Flags with carried forward coverage won't be shown. Click here to find out more. see 546 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #7638
This PR is to fix an issue where as in #7638, the
strategies.yamldoes not include aparent_is_proxyvalue for any servers in the file. This PR also fixes an issue from tech debt where thestrategiesdotconfig.gois supposed to bestrategiesdotyaml.gosince the file changed from.configto.yamlWhich Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
I have added a test in
strategiesdotyaml_tests.go, the function isTestMakeStrategiesDotYAMLParentIsProxywhich tests whenopt.ParentIsProxyis set totrueand when it is set tofalse.If this is a bugfix, which Traffic Control versions contained the bug?
I would imagine all existing versions have this issue since switching to
.yamlstructure.PR submission checklist
This PR doesn't need documentation since it has everything already documented in ATS's page. This is just fixing a behavior we were expecting.