-
Notifications
You must be signed in to change notification settings - Fork 29.4k
[SPARK-59456][SQL] Fix: RuleExecutor.PlanChangeLogger does work even when it doesn't log - #58755
Open
bhollis-dbx wants to merge 1 commit into
Open
[SPARK-59456][SQL] Fix: RuleExecutor.PlanChangeLogger does work even when it doesn't log #58755bhollis-dbx wants to merge 1 commit into
bhollis-dbx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a functional
withLogLevelhelper to Logging to make it easy to skip work when the log level is below a target.Then used that in
RuleExecutor.PlanChangeLoggerto avoid callingfastEqualsunnecessarily.Why are the changes needed?
The existing code always called
fastEquals, even when it couldn't log anything because of the log leve..Does this PR introduce any user-facing change?
No
How was this patch tested?
The change itself is trivial.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex CLI 0.147.0 (GPT-5)