-
Notifications
You must be signed in to change notification settings - Fork 192
[WIP] ByteString Two-Way string matching in indexOfSlice #2324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pjfanning
Copy link
Member
@pjfanning
pjfanning
commented
Oct 18, 2025
- See [WIP] use getLong when matching byte sequences in ByteString #2323 and Revisit indexOfSlice performance improvements #2321
- the aim is to benchmark both solutions - this one is more complicated so it would need to be much better to justify being used
@pjfanning
pjfanning
force-pushed
the
bs-2waysearch
branch
from
October 18, 2025 17:15
69114aa to
f90969d
Compare
@pjfanning
pjfanning
changed the title
(削除) ByteString Two-Way string matching in indexOfSlice (削除ここまで)
(追記) [WIP] ByteString Two-Way string matching in indexOfSlice (追記ここまで)
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.