Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix uncurried stream ops in javadsl #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdedetrich wants to merge 1 commit into apache:1.0.x
base: 1.0.x
Choose a base branch
Loading
from mdedetrich:add-uncurried-flow-functions-deprecate-old

Conversation

@mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Jul 21, 2024
edited
Loading

(cherry picked from commit f9ad446)

Since this change has been determined to be completely safe (see #1406 (comment) and thread in general) I think its a good candidate to cherry pick back to the 1.0.x series since if we ever do another release in the 1.0.x series it will mean that the docs/source/syntax completion will be better

Copy link
Member

He-Pin commented Jul 21, 2024
edited
Loading

I think we better keep it in 1.1.x, @pjfanning ,wdyt? I don't have strong option on this.

Copy link
Member

I'd prefer to hold off on this. Can we focus on getting 1.1.0 released?

Copy link
Contributor Author

I'd prefer to hold off on this. Can we focus on getting 1.1.0 released?

Well reviewing/merging this isn't going to have an impact on 1.1.0 one way or another

Regarding 1.1.0, I am not sure if there was a discussion on the release plan (I have been a bit out of the loop as of late), or more specifically is the idea that we are meant to wait for a bit just to be sure that its stable (we are currently using 1.1.0-M1 in production), if so its best to wait to get feedback from a critical amount of users.

Copy link
Member

I'd prefer to hold off on this. Can we focus on getting 1.1.0 released?

Well reviewing/merging this isn't going to have an impact on 1.1.0 one way or another

Regarding 1.1.0, I am not sure if there was a discussion on the release plan (I have been a bit out of the loop as of late), or more specifically is the idea that we are meant to wait for a bit just to be sure that its stable (we are currently using 1.1.0-M1 in production), if so its best to wait to get feedback from a critical amount of users.

My point is that we have been very conservative with 1.0.x changes. I would prefer not to merge this to 1.0.x. We can have the 1.1.0 release discussion on the mailing list. There are a few open issues but we could probably consider releasing 1.1.0-M2 soon or even doing 1.1.0 instead.

Copy link
Contributor Author

mdedetrich commented Jul 21, 2024
edited
Loading

My point is that we have been very conservative with 1.0.x changes. I would prefer not to merge this to 1.0.x.

Sure, but conservative doesn't mean "none at all" and at least currently without these changes, for cross Java/Scala projects the effected parts in javadsl is currently broken when it comes to IDE's syntax highlighting and considering that it has zero impact on bytecode (and people are using 1.0.x) I think that this should pass the bar, we have certainly merged things into 1.0.x on a lot less than this.

Lets keep the 1.1.0 release discussion out of this issue, there wasn't any reason to bring it up as it has nothing to do with this.

Copy link
Member

He-Pin commented Jul 22, 2024

I'm not using Kotlin with pekko-stream, but the current one works ok with Java, even with Java21, do you have a screenshot where is cause problem when work with Kotlin @mdedetrich

Copy link
Member

He-Pin commented Nov 15, 2025

@mdedetrich should this retarget 2.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrudolph jrudolph Awaiting requested review from jrudolph

@raboof raboof Awaiting requested review from raboof

@gmethvin gmethvin Awaiting requested review from gmethvin

@nivox nivox Awaiting requested review from nivox

@He-Pin He-Pin Awaiting requested review from He-Pin

@nvollmar nvollmar Awaiting requested review from nvollmar

@danischroeter danischroeter Awaiting requested review from danischroeter

@samueleresca samueleresca Awaiting requested review from samueleresca

@pjfanning pjfanning Awaiting requested review from pjfanning

@Roiocam Roiocam Awaiting requested review from Roiocam

@jxnu-liguobin jxnu-liguobin Awaiting requested review from jxnu-liguobin

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /