Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

introduce explaining variable refactoring.#170

Open
Vivek504 wants to merge 1 commit intoapache:trunk from
Vivek504:introduce-explaining-variable-refactoring
Open

introduce explaining variable refactoring. #170
Vivek504 wants to merge 1 commit intoapache:trunk from
Vivek504:introduce-explaining-variable-refactoring

Conversation

@Vivek504
Copy link

@Vivek504 Vivek504 commented Nov 18, 2023

Introduce Explaining Variable Refactoring

Reason: Long Statement

  1. The length of the statement "final MethodHandle nonNullTest=lookup.findStatic(Objects.class,"nonNull",methodType(boolean.class,Object.class)).asType(methodType(boolean.class,cleanerClass));" is 160.
  2. The length of the statement "final MethodHandle unmapper=filterReturnValue(directBufferCleanerMethod,guardWithTest(nonNullTest,cleanMethod,noop)).asType(methodType(void.class,ByteBuffer.class));" is 165.

Logic of the refactoring: Complicated expressions are replaced by explaining variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /