-
Notifications
You must be signed in to change notification settings - Fork 942
Comments
Open
Conversation
Contributor
THausherr
commented
Nov 18, 2023
This is an example class. There is no need to refactor it and create an additional class.
Author
Vivek504
commented
Nov 18, 2023
Thanks for your quick feedback. I'll try to contribute if there is a need of refactoring any other class instead of Example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract Class Refactoring
Location of the class: org.apache.pdfbox.examples.pdmodel.CreatePatternsPDF
Reason: Imperative Abstraction - The tool detected the smell in this class because it looks like that an operation is turned into a class. This class contains only the following public method: main
Logic of the refactoring: New class (PatternDrawer) is created to refactor the code and refactored code separates the responsibilities of two classes (CreatePatternsPDF and PatternDrawer).