-
Notifications
You must be signed in to change notification settings - Fork 517
Draft
Conversation
Treat a stream's exact logical end as a valid seek target even when the shared disk range list contains data for later streams. This prevents an EOF seek from selecting an unrelated range or failing as out of bounds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update
InStream.UncompressedStream.seek(long)to treat the stream's exact logical end as a valid seek position when the shared disk range list contains later ranges for other streams. Add a regression test covering a logical-end seek followed by an unrelated disk range.Why are the changes needed?
A stream may end at a disk range that is not the final node in the shared range list. The existing logic rejects that range end or selects a later range, although seeking to
lengthis a valid EOF position for the current stream.How was this patch tested?
JAVA_HOME=$(/usr/libexec/java_home -v 21) ./mvnw -pl core -am -Dtest=TestInStream -Dsurefire.failIfNoSpecifiedTests=false testWas this patch authored or co-authored using generative AI tooling?
Generated-by: GitHub Copilot CLI 1.0.80