-
Notifications
You must be signed in to change notification settings - Fork 517
Open
Conversation
wgtmac
force-pushed
the
protobuf_33.5
branch
from
February 26, 2026 03:16
f0981ae to
30f84a7
Compare
It looks like a 34.0 release came out upstream: https://github.com/protocolbuffers/protobuf/releases/tag/v34.0. I mention it in particular because it adds [[nodiscard]] to many functions, and when compiling with STOP_BUILD_ON_WARNING set to true, it can cause build failures (we encountered this in Nixpkgs with logs like https://hydra.nixos.org/build/323335244/log, since we try to link to the latest library versions wherever possible). Just wanted to leave a note for when y'all end up upgrading to that version :)
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bump protobuf to v33.5 which is the latest stable version at the moment.
Why are the changes needed?
Protobuf dependency has not been upgraded for several years and it would be a good chance to bump it with 3.0.0.
How was this patch tested?
Pass CIs.
Was this patch authored or co-authored using generative AI tooling?
No.