-
Notifications
You must be signed in to change notification settings - Fork 517
Add a copyright messaging to the BpackingAvx512.hh - #1691
Conversation
@dongjoon-hyun
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making a PR, @guangzegu .
Actually, here is the ASF legal policy.
Do not add the standard Apache License header to the top of third-party source files.
If this file falls into third-party source file, we need to remove ASF License.
cc @wpleonardo as the author of this PR.
cc @wgtmac , @williamhyun , @stiga-huang , @coderex2522 from #1375 reviewers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give us the original source link?
wgtmac
commented
Dec 13, 2023
If we need to regard the code as third-party and remove ASF license header, some refactoring work is required to isolate code from Intel QPL and then add the copyright. It seems that BpackingAvx512.hh is mix of ORC RLE decoder interface and AVX512 implementation.
If we need to regard the code as third-party and remove ASF license header, some refactoring work is required to isolate code from Intel QPL and then add the copyright. It seems that
BpackingAvx512.hhis mix of ORC RLE decoder interface and AVX512 implementation.↳
It would be even better if you could provide the original source of the code.
I haven't checked if the referenced code has been modified on top of it, but if so, we can also add the corresponding AL2 header. FYI https://issues.apache.org/jira/browse/LEGAL-626
wpleonardo
commented
Jul 22, 2024
If we need to regard the code as third-party and remove ASF license header, some refactoring work is required to isolate code from Intel QPL and then add the copyright. It seems that
BpackingAvx512.hhis mix of ORC RLE decoder interface and AVX512 implementation.↳It would be even better if you could provide the original source of the code. I haven't checked if the referenced code has been modified on top of it, but if so, we can also add the corresponding AL2 header. FYI https://issues.apache.org/jira/browse/LEGAL-626
The source code link: https://github.com/intel/qpl/blob/c2ced94c53c1ee22191201a59878e9280bc9b9b8/sources/core-sw/src/filtering/opt/qplc_unpack_be_8u_k0.h#L158
This implementation of this part is referred to Intel/qpl code.
@wgtmac @dongjoon-hyun So sorry for late response. Something happened in my family in the past half a year.
wgtmac
commented
Jul 23, 2024
@wpleonardo Sorry to hear that
What changes were proposed in this pull request?
Add copyright messaging to BpackingAvx512.hh
Why are the changes needed?
The vector unpacking functions in this PR https://github.com/apache/orc/pull/1375 is derived from Intel's QPL library, hence, Maybe copyright messaging should be added.
QPL Link: https://github.com/intel/qpl
How was this patch tested?
N/A