-
Notifications
You must be signed in to change notification settings - Fork 14.9k
MINOR: Use TransactionOperation enum instead of String for pending state checks #21218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chickenchickenlove
wants to merge
1
commit into
apache:trunk
from
chickenchickenlove:251229-no-issue
Open
MINOR: Use TransactionOperation enum instead of String for pending state checks #21218
chickenchickenlove
wants to merge
1
commit into
apache:trunk
from
chickenchickenlove:251229-no-issue
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@github-actions
github-actions
bot
added
triage
PRs from the community
producer
clients
small
Small PRs
labels
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
PR Description
this PR refactors
TransactionManager#throwIfPendingStateto use a typedTransactionOperationenum instead of a raw String.###Background / Motivation
The previous String-based API relies on manually passing operation names, which can make it easier for naming to drift or become inconsistent over time. Using an enum makes the intent more explicit and keeps the operation naming centralized.
What’s changed
TransactionOperationenum with adisplayName(andtoString()override) to preserve readable exception messages.beginTransaction,prepareTransaction,sendOffsetsToTransaction,maybeAddPartition) to pass the corresponding enum value.throwIfPendingStateto acceptTransactionOperationinstead ofString.Behavior / Compatibility
TransactionOperation#toString().Testing
No additional tests were added since this is a small refactor; existing tests should continue to cover the pending-transition behavior.