-
Notifications
You must be signed in to change notification settings - Fork 14.9k
MINOR: Simplify Tests Independent from Consumer in BaseProducerSendTest #21215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jack2012aa
wants to merge
2
commits into
apache:trunk
from
jack2012aa:Minor-Cleanup-PlaintextProducerSendTest
Open
MINOR: Simplify Tests Independent from Consumer in BaseProducerSendTest #21215
jack2012aa
wants to merge
2
commits into
apache:trunk
from
jack2012aa:Minor-Cleanup-PlaintextProducerSendTest
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala
@github-actions
github-actions
bot
added
triage
PRs from the community
core
Kafka Broker
tests
Test fixes (including flaky tests)
small
Small PRs
labels
Dec 28, 2025
@chia7712
chia7712
changed the title
(削除) Minor: Simplify Tests Independent from Consumer in BaseProducerSendTest (削除ここまで)
(追記) MINOR: Simplify Tests Independent from Consumer in BaseProducerSendTest (追記ここまで)
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
As discussed in the
comment,
some tests in
BaseProducerSendTestdidn't use consumer at all.Since the testInfo parameter is required by
QuorumTestHarness, this PRlets those tests pass
getTestGroupProtocolParametersConsumerGroupProtocolOnlyas parameterinstead of parameters all.