-
Notifications
You must be signed in to change notification settings - Fork 444
Comments
Added implementation to delete file and CLI to add file#2997
Open
subkanthi wants to merge 10 commits intoapache:main from
Open
Added implementation to delete file and CLI to add file #2997subkanthi wants to merge 10 commits intoapache:main from
subkanthi wants to merge 10 commits intoapache:main from
Conversation
@subkanthi
subkanthi
changed the title
(削除) Added implementation to delete file. (削除ここまで)
(追記) Added implementation to delete file and CLI to add file (追記ここまで)
Feb 11, 2026
Fokko
Fokko
reviewed
Feb 20, 2026
result: dict[str, DataFile] = {}
for manifest in snapshot.manifests(io):
if manifest.content == ManifestContent.DATA:
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also drop related deletes?
Fokko
Fokko
reviewed
Feb 20, 2026
return [f.result() for f in futures if f.result()]
def _get_data_files_from_snapshot(
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use metadata tables for this? I'd like to avoid functions like these since they do not parallelize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Closes #2787
Rationale for this change
To be in parity with java and rust to support delete files.
Are these changes tested?
Yes
Are there any user-facing changes?
Yes