-
Notifications
You must be signed in to change notification settings - Fork 124
chore(test): run REST fixture's SQLite backend in WAL mode - #931
Open
kevinjqliu wants to merge 1 commit into
Open
chore(test): run REST fixture's SQLite backend in WAL mode #931kevinjqliu wants to merge 1 commit into
kevinjqliu wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
5 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Approval recommended
The change is a small, targeted docker-compose configuration update that aligns with the stated goal of reducing SQLite lock contention.
Pull request overview
Updates the Iceberg REST test fixture’s docker-compose configuration to use a file-backed SQLite catalog database in WAL mode to reduce SQLITE_BUSY lock contention when tests run parallel clients.
Changes:
- Fixes the SQLite JDBC URL to point to an explicit file path instead of an accidentally file-backed "mode=memory" filename.
- Enables SQLite WAL journaling via
journal_mode=WALin the JDBC URL to improve concurrent access behavior.
File summaries
| File | Description |
|---|---|
| src/iceberg/test/resources/iceberg-rest-fixture/docker-compose.yml | Switch SQLite JDBC URL to a real file-backed DB and enable WAL mode for better parallel test reliability. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wgtmac
wgtmac
approved these changes
Sep 10, 2026
zhjwpku
zhjwpku
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of apache/iceberg#18043
The REST fixture compose sets
CATALOG_URI=jdbc:sqlite:file:/tmp/iceberg_rest_mode=memory, carried over from the old databricks image. That isn't an in-memory db, there's no?soiceberg_rest_mode=memoryis just part of the filename. It's a file-backed SQLite db on the default rollback journal, which only lets one connection touch the db at a time, so parallel clients can fail withSQLITE_BUSY("database is locked").This switches it to
jdbc:sqlite:/tmp/iceberg_catalog.db?journal_mode=WAL, matching the new fixture default in apache/iceberg#18044.🤖 Generated with Claude Code