Skip to content

Navigation Menu

Sign in
Sign up

feat: add Nimble to FileFormatType #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzhao0 wants to merge 1 commit into apache:main
base: main
Choose a base branch
Loading
from zzhao0:nimble-file-format
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/iceberg/file_format.h
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ enum class ICEBERG_EXPORT FileFormatType {
kAvro,
kOrc,
kPuffin,
kNimble,
};

/// \brief Convert a FileFormatType to a string
Expand All @@ -50,6 +51,8 @@ ICEBERG_EXPORT inline std::string_view ToString(FileFormatType format_type) {
return "orc";
case FileFormatType::kPuffin:
return "puffin";
case FileFormatType::kNimble:
return "nimble";
}
std::unreachable();
}
Expand All @@ -62,6 +65,7 @@ ICEBERG_EXPORT inline Result<FileFormatType> FileFormatTypeFromString(
if (lower == "avro") return FileFormatType::kAvro;
if (lower == "orc") return FileFormatType::kOrc;
if (lower == "puffin") return FileFormatType::kPuffin;
if (lower == "nimble") return FileFormatType::kNimble;
return InvalidArgument("Invalid file format type: {}", str);
}

Expand Down
Loading

AltStyle によって変換されたページ (->オリジナル) /