-
Notifications
You must be signed in to change notification settings - Fork 615
Open
Conversation
@dosubot
dosubot
Bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
store
Store module
labels
Jan 27, 2026
@github-project-automation
github-project-automation
Bot
moved this to In progress
in HugeGraph PD-Store Tasks
Jan 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@ ## master #2945 +/- ## ============================================ - Coverage 35.61% 1.57% -34.04% + Complexity 333 43 -290 ============================================ Files 801 779 -22 Lines 67533 65018 -2515 Branches 8780 8332 -448 ============================================ - Hits 24053 1026 -23027 - Misses 40916 63906 +22990 + Partials 2564 86 -2478 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
imbajin
imbajin
reviewed
Jan 27, 2026
imbajin
imbajin
reviewed
Jan 27, 2026
imbajin
imbajin
reviewed
Jan 27, 2026
imbajin
imbajin
reviewed
Jan 27, 2026
imbajin
imbajin
reviewed
Jan 27, 2026
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances security for Arthas debugging endpoints by restricting remote access and standardizing configuration naming patterns across the codebase.
Changes:
- Added localhost-only access restriction to the store node's arthasstart endpoint
- Standardized Arthas configuration property names from snake_case to camelCase (e.g.,
arthas.telnet_port→arthas.telnetPort) - Changed default Arthas IP binding from
0.0.0.0to127.0.0.1and expanded disabled commands to includejad,ognl,vmtool
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| hugegraph-store/hg-store-node/src/main/resources/application.yml | Added Arthas configuration with localhost-only IP binding and expanded disabled commands |
| hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/controller/PartitionAPI.java | Added remote access check to arthasstart endpoint and new forbiddenMap helper method |
| hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/AppConfig.java | Updated default values for Arthas IP and disabled commands |
| hugegraph-server/hugegraph-dist/src/assembly/static/conf/rest-server.properties | Renamed Arthas properties to camelCase and updated default values |
| hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java | Updated default values for Arthas IP binding and disabled commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
imbajin
imbajin
reviewed
Jan 29, 2026
imbajin
imbajin
reviewed
Jan 29, 2026
imbajin
imbajin
reviewed
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@JisoLya
JisoLya
changed the title
(削除) sec(store, server): disable remote access for arthasstart and fix inconsistent naming pattern (削除ここまで)
(追記) fix: fix inconsistent naming pattern (追記ここまで)
Jan 29, 2026
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Currently, the configuration keys in rest-server.properties use snake_case (e.g., server_port), which is inconsistent with the naming convention expected by ServerOptions.java. This mismatch causes the following issues:
Terminal logs show warnings such as: "arthas.xxxx is redundant ...", indicating that the properties are not being recognized or registered.
image
image
image