-
Notifications
You must be signed in to change notification settings - Fork 19.8k
Comments
fix: axisLabel.height should work without backgroundColor (#21504)#21505
fix: axisLabel.height should work without backgroundColor (#21504) #21505SakshamSinghal20 wants to merge 2 commits intoapache:master from
Conversation
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.
Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only.
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged
This message is shown because the PR description doesn't contain the document related template.
SakshamSinghal20
commented
Feb 1, 2026
@plainheart @100pah could you please review this at your convenience?
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21505@a7194cc
@Ovilia
Ovilia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check your test file. It shows nothing on my side. Make sure the test cases are created using npm run mktest axis-label-height-without-bg 3.
Please don't include FIX_SUMMARY.md.
The source code patch itself looks good to me. Thanks.
SakshamSinghal20
commented
Feb 9, 2026
Hi @Ovilia I have done what you asked for let me know if there is anything that i need to do.
Thank you,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this is the right way to fix the issue. As I mentioned earlier #21504 (comment), this behavior is likely intentional by design, but it did not account for cases where the text has explicit width, height, or padding. In such situations, the text background box should still be drawn, even when no background color is specified.
I would suggest either implementing the fix at the underlying ZRender, or simply not fixing this "bug" at all, since there is already a simple workaround to avoid the problem.
Summary
Fixes axisLabel.height property to work independently of backgroundColor.
Changes
Fixes #21504