-
Notifications
You must be signed in to change notification settings - Fork 19.8k
Comments
fix(legend): fallback to horizontal if orient is invalid#21450
fix(legend): fallback to horizontal if orient is invalid #21450dilipkumar6306316-art wants to merge 5 commits intoapache:master from
Conversation
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.
Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only.
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged
This message is shown because the PR description doesn't contain the document related template.
@plainheart
plainheart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please do not commit the files in the
distfolder. - Please do not use any formatter tool.
- Please recover all the changes that are not related to your fix.
Justin-ZS
commented
Jan 4, 2026
I suggest not fixing this case, as invalid orient are widely used as a workaround for multiple line scroll legend. (16912)
dilipkumar6306316-art
commented
Jan 4, 2026
Thanks for the clarification and for sharing the context.
I checked the referenced issue (#16912) as well and understand that fixing this
case was intentionally avoided earlier, since invalid orient values are
already being used by users as a workaround for multi-line scroll legends.
Changing this behavior could break existing usage and affect scenarios where
multiple scroll legends are created.
Given this context, I understand that fixing this case in code might not be
desirable. I’ll wait for your guidance on whether this should be handled via
documentation instead, or if the PR should be closed.
Summary
This PR fixes a bug in the Legend component (#21400) where providing an invalid
legend.orientvalue caused unexpected width/height behavior in scroll legends.Changes
legend.orientindexhorizontalandverticalorient values remains unchangedTesting
Related Issue
Closes #21400