-
Notifications
You must be signed in to change notification settings - Fork 19.8k
Comments
Fix/toolbox selection chart rerender#21375
Open
Srajan-Sanjay-Saxena wants to merge 1 commit intoapache:master from
Open
Fix/toolbox selection chart rerender #21375Srajan-Sanjay-Saxena wants to merge 1 commit intoapache:master from
Srajan-Sanjay-Saxena wants to merge 1 commit intoapache:master from
Conversation
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.
Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only.
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged
This message is shown because the PR description doesn't contain the document related template.
plainheart
plainheart
requested changes
Nov 15, 2025
@echarts-bot
echarts-bot
bot
added
PR: revision needed
PR: awaiting review
and removed
PR: awaiting review
PR: revision needed
labels
Nov 15, 2025
@Srajan-Sanjay-Saxena
Srajan-Sanjay-Saxena
requested a review
from plainheart
November 15, 2025 11:04
@Srajan-Sanjay-Saxena
Srajan-Sanjay-Saxena
force-pushed
the
fix/toolbox-selection-chart-rerender
branch
from
November 15, 2025 15:16
8343a46 to
165facc
Compare
@Srajan-Sanjay-Saxena
Srajan-Sanjay-Saxena
force-pushed
the
fix/toolbox-selection-chart-rerender
branch
from
November 15, 2025 15:21
165facc to
19e7eb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Prevents unnecessary chart re-rendering when clicking toolbox buttons (brush, dataZoom selection tools) by skipping series rendering for
takeGlobalCursoractions.Fixed issues
Details
Before: What was the problem?
When users clicked toolbox buttons like "Box Select" (brush rect) or dataZoom selection tools, the entire chart would re-render including all series data points. This triggered:
Root Cause: The
takeGlobalCursoraction was registered withupdate: 'update', which triggered the full update pipeline includingrender()→renderSeries(), causing all chart series to re-render even though only UI state (toolbox icons, brush controller) needed updating.Investigation Journey:
update: 'update'toupdate: 'none'and manually calling component updates in a custom action handlerupdate: 'toolbox:updateView'and other targeted update strategiesAfter: How does it behave after the fixing?
Clicking toolbox buttons now:
The Fix: Added a simple early return in the
render()function to skip series rendering when the payload type istakeGlobalCursor:i am attaching a video of the fix
2025年11月15日.01-18-41.mp4