-
Notifications
You must be signed in to change notification settings - Fork 19.8k
Comments
fix: dataZoom incorrectly filters stacked data#21372
fix: dataZoom incorrectly filters stacked data #21372archiewood wants to merge 1 commit intoapache:master from
Conversation
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.
Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only.
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged
This message is shown because the PR description doesn't contain the document related template.
updated to conform to PR template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be unexpected to me because this makes const dataDims = seriesData.mapDimensionsAll(axisDim); almost useless.
Found these comments might be related. @100pah Please help review this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be unexpected to me because this makes const dataDims = seriesData.mapDimensionsAll(axisDim); almost useless.
- The
mapDimensionsAll(axisDim)call is necessary to get all dimensions that map to this axis. - Then
getStackedDimension()transforms each dimension to its stacked result dimension only if that dimension is stacked - otherwise it returns the original dimension unchanged.
an alternative would be maybe to define dataDims like this, and then not overwrite the elements later, I was just concerned this would be less clear
const dataDims = zrUtil.map( seriesData.mapDimensionsAll(axisDim), dim => getStackedDimension(seriesData, dim) );
archiewood
commented
Dec 1, 2025
Let me know if there is anything you would like me to do here, for example the refactor I mentioned above
archiewood
commented
Jan 23, 2026
Hi all, let me know if this is of interest.
This would be beneficial for us as we are currently patching echarts to work around this issue.
Uh oh!
There was an error while loading. Please reload this page.
Brief Information
This pull request is in the type of:
What does this PR do?
fixes #21371 dataZoom + stacked series + scale causing missing datapoints.
Fixed issues
#21371
Details
Before: What was the problem?
DataZoom calculated valueWindow from stacked extents but filtered using original (unstacked) dimension values, causing incorrect point removal.
After: How does it behave after the fixing?
Transform dimensions to use stackResultDimension before filtering.
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Merging options